Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time #124

Closed
wants to merge 10 commits into from
Closed

Time #124

wants to merge 10 commits into from

Conversation

aleeusgr
Copy link
Owner

@aleeusgr aleeusgr commented Jun 15, 2023 •
edited
Loading

  • refactor: again, how to organize tests?

aleeusgr
aleeusgr commented Jun 15, 2023
View reviewed changes
tests/time-props-vesting.test.ts
const validatorAddress = Address.fromValidatorHash(validatorHash);

const adaQty = 10;
const duration = 1000000;
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two lines duplicate, add to context or hardcode

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also duration can be obtained from slot number and used to explore edge cases also

tests/vesting-cancel.test.ts
@@ -56,11 +56,14 @@ describe("a vesting contract: Cancel transaction", async () => {
const aliceUtxos = await alice.utxos;
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm

@aleeusgr aleeusgr closed this Jun 22, 2023
@aleeusgr aleeusgr deleted the time branch April 5, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@aleeusgr