Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: revert upgrade: aiohttp 3.10.2 -> 3.9.5 #242

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

philogicae
Copy link
Member

This new merged PR broke aleph-client on Windows: #239
The only fix right now seems to be downgrading to 3.9.5, according to nathom/streamrip#729
image

Copy link

Summary:

  • The PR introduces a change in the version of aiohttp, a major dependency.
  • This change can have significant implications for the library's functionality and may introduce compatibility issues.

Highlights:

  • aiohttp==3.9.5: This version change is the primary reason for the 'BLACK' rating. It's a major dependency and such changes should be carefully reviewed due to potential compatibility issues.
- "aiohttp==3.10.2",
+ "aiohttp==3.9.5",

@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Aug 13, 2024
@Psycojoker
Copy link
Collaborator

Damn x(

We really need tests on aleph-client like we've discussed yesterday :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLACK This PR has critical implications and must be reviewed by a senior engineer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants