feature: traits for client functionalities #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the functionalities of `AlephClient` into multiple traits (currently one to retrieve messages, one to retrieve storage objects). This will help later on to implement modified clients based on the default one or mock specific functions without having to reimplement the entire Aleph API. This introduces a breaking change as users now have to import the traits they need when using `AlephClient`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the functionalities of
AlephClientinto multiple traits (currently one to retrieve messages, one to retrieve storage objects). This will help later on to implement modified clients based on the default one or mock specific functions without having to reimplement the entire Aleph API.This introduces a breaking change as users now have to import the traits they need when using
AlephClient.