-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deps: Update Kubo IPFS 0.23.0 -> 0.27.0 #504
base: main
Are you sure you want to change the base?
Conversation
a066a55
to
ef764df
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
=======================================
Coverage 62.58% 62.58%
=======================================
Files 69 69
Lines 6140 6140
Branches 496 496
=======================================
Hits 3843 3843
Misses 2147 2147
Partials 150 150 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be tested intensively, but LGTM
I tested on Debian 12 and it seemed to work fine (service started, can download CIDs), but the CI reports the following error on Debian 11:
Note that this service is not used by CRNs yet, we have a task to change that. |
ef764df
to
9091f93
Compare
I'm rebasing and relaunching CI since we dropped Debian 11 this should not be blocking anymore |
Work in progress since we have an issue on Debian 11:
Kubo 0.24.0 attempted to read some
allow_list
in a directory that is not allowed to be accessed on Debian 11, linked to the security hardening of the service file.See https://github.com/aleph-im/aleph-vm/blob/main/packaging/aleph-vm/etc/systemd/system/ipfs.service#L28-L52
This appears to not cause any issue in version 0.27.0 anymore.