Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: Update Kubo IPFS 0.23.0 -> 0.27.0 #504

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

hoh
Copy link
Member

@hoh hoh commented Dec 12, 2023

Work in progress since we have an issue on Debian 11:

Kubo 0.24.0 attempted to read some allow_list in a directory that is not allowed to be accessed on Debian 11, linked to the security hardening of the service file.

See https://github.com/aleph-im/aleph-vm/blob/main/packaging/aleph-vm/etc/systemd/system/ipfs.service#L28-L52

This appears to not cause any issue in version 0.27.0 anymore.

@hoh hoh marked this pull request as draft December 12, 2023 14:20
@aleph-im aleph-im deleted a comment from github-actions bot Dec 12, 2023
@hoh hoh added the question Further information is requested label Feb 1, 2024
@hoh hoh force-pushed the hoh-upgrade-kubo-0.24.0 branch from a066a55 to ef764df Compare March 7, 2024 16:05
@hoh hoh changed the title Deps: Update Kubo IPFS 0.23.0 -> 0.24.0 Deps: Update Kubo IPFS 0.23.0 -> 0.27.0 Mar 7, 2024
@hoh hoh marked this pull request as ready for review March 7, 2024 16:06
@hoh hoh requested a review from nesitor March 7, 2024 16:06
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.58%. Comparing base (b113406) to head (8b75354).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #504   +/-   ##
=======================================
  Coverage   62.58%   62.58%           
=======================================
  Files          69       69           
  Lines        6140     6140           
  Branches      496      496           
=======================================
  Hits         3843     3843           
  Misses       2147     2147           
  Partials      150      150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nesitor nesitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be tested intensively, but LGTM

@aleph-im aleph-im deleted a comment from github-actions bot Mar 8, 2024
@hoh
Copy link
Member Author

hoh commented Mar 8, 2024

I tested on Debian 12 and it seemed to work fine (service started, can download CIDs), but the CI reports the following error on Debian 11:

Created symlink /etc/systemd/system/default.target.wants/ipfs.service → /etc/systemd/system/ipfs.service.
Job for ipfs.service failed because the control process exited with error code.
See "systemctl status ipfs.service" and "journalctl -xe" for details.
dpkg: error processing package aleph-vm (--configure):

Note that this service is not used by CRNs yet, we have a task to change that.

@hoh hoh force-pushed the hoh-upgrade-kubo-0.24.0 branch from ef764df to 9091f93 Compare March 14, 2024 09:15
@olethanh
Copy link
Collaborator

olethanh commented Nov 5, 2024

I'm rebasing and relaunching CI since we dropped Debian 11 this should not be blocking anymore

@olethanh olethanh assigned olethanh and unassigned nesitor Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants