Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Upgrade Firecracker 1.5.0 -> 1.7.0 #771

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Conversation

hoh
Copy link
Member

@hoh hoh commented Mar 4, 2025

This bumps their versions to

  • Firecracker 1.5.0 -> 1.7.0

Most changes related to Firecracker are regarding
the snapshots, which are not used by aleph-vm.

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.50%. Comparing base (eff82dc) to head (4d38d92).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #771   +/-   ##
=======================================
  Coverage   64.50%   64.50%           
=======================================
  Files          78       78           
  Lines        7088     7088           
  Branches      598      598           
=======================================
  Hits         4572     4572           
  Misses       2314     2314           
  Partials      202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hoh hoh self-assigned this Mar 5, 2025
@hoh hoh force-pushed the hoh-upgrade-firecracker branch from 7dea032 to c406de5 Compare March 11, 2025 13:02
@hoh
Copy link
Member Author

hoh commented Mar 11, 2025

When trying with version 1.8.0:

Mar 11 13:51:15 test-crn-hugo vm-67705389842a0a1b95eaa408b009741027964edc805997475e95c505d642edd8-stdout[439545]: [    1.775291] VFS: Cannot open root device "vda" or unknown-block(0,0): error -6
Mar 11 13:51:15 test-crn-hugo vm-67705389842a0a1b95eaa408b009741027964edc805997475e95c505d642edd8-stdout[439545]: [    1.779336] Please append a correct "root=" boot option; here are the available partitions:
Mar 11 13:51:15 test-crn-hugo vm-67705389842a0a1b95eaa408b009741027964edc805997475e95c505d642edd8-stdout[439545]: [    1.783629] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0)
Mar 11 13:51:15 test-crn-hugo vm-67705389842a0a1b95eaa408b009741027964edc805997475e95c505d642edd8-stdout[439545]: [    1.787602] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.10.197 #1
Mar 11 13:51:15 test-crn-hugo vm-67705389842a0a1b95eaa408b009741027964edc805997475e95c505d642edd8-stdout[439545]: [    1.787602] Call Trace:
Mar 11 13:51:15 test-crn-hugo vm-67705389842a0a1b95eaa408b009741027964edc805997475e95c505d642edd8-stdout[439545]: [    1.787602]  show_stack+0x3a/0x40
Mar 11 13:51:15 test-crn-hugo vm-67705389842a0a1b95eaa408b009741027964edc805997475e95c505d642edd8-stdout[439545]: [    1.787602]  dump_stack+0x5e/0x78
Mar 11 13:51:15 test-crn-hugo vm-67705389842a0a1b95eaa408b009741027964edc805997475e95c505d642edd8-stdout[439545]: [    1.787602]  panic+0x108/0x2d3
Mar 11 13:51:15 test-crn-hugo vm-67705389842a0a1b95eaa408b009741027964edc805997475e95c505d642edd8-stdout[439545]: [    1.787602]  mount_block_root+0x215/0x293
Mar 11 13:51:15 test-crn-hugo vm-67705389842a0a1b95eaa408b009741027964edc805997475e95c505d642edd8-stdout[439545]: [    1.787602]  ? done_path_create+0x3d/0x50
Mar 11 13:51:15 test-crn-hugo vm-67705389842a0a1b95eaa408b009741027964edc805997475e95c505d642edd8-stdout[439545]: [    1.787602]  mount_root+0x65/0x6c
Mar 11 13:51:15 test-crn-hugo vm-67705389842a0a1b95eaa408b00

@hoh hoh force-pushed the hoh-upgrade-firecracker branch from c406de5 to 9bcf8a4 Compare March 11, 2025 13:53
@hoh hoh changed the title Fix: Packages used obsolete Firecracker Fix: Upgrade Firecracker 1.5.0 -> 1.7.0 Mar 11, 2025
@hoh hoh marked this pull request as ready for review March 12, 2025 07:44
@hoh hoh force-pushed the hoh-upgrade-firecracker branch from 9bcf8a4 to bf52627 Compare March 12, 2025 08:50
@hoh hoh requested a review from olethanh March 18, 2025 14:37
@nesitor nesitor force-pushed the hoh-upgrade-firecracker branch 2 times, most recently from 5b019d9 to 215870d Compare March 31, 2025 15:30
This bumps their versions to
- Firecracker 1.5.0 -> 1.7.0

Newer releases require some changes.
@olethanh olethanh force-pushed the hoh-upgrade-firecracker branch from 215870d to 4d38d92 Compare April 1, 2025 08:50
@olethanh olethanh merged commit 2221cd4 into main Apr 1, 2025
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants