Add automatic snapshot feature for QEMU VMs #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add automatic snapshots for QEMU VMs every 10 minutes by default - Create QemuSnapshotManager to handle QEMU VM snapshot scheduling - Implement create_snapshot method in AlephQemuInstance using QMP - Keep only one active snapshot at a time, deleting previous ones - Make QEMU confidential VMs also support snapshots - Update pool and execution classes to use appropriate snapshot manager 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Psycojoker
reviewed
Mar 19, 2025
| """ | ||
| try: | ||
| logger.debug(f"Creating snapshot {snapshot_name} for VM {self.vm.vm_id}") | ||
| self.qmp_client.command("savevm", **{"name": snapshot_name}) |
There was a problem hiding this comment.
Suggested change
| self.qmp_client.command("savevm", **{"name": snapshot_name}) | |
| self.qmp_client.command("savevm", name=snapshot_name) |
| """ | ||
| try: | ||
| logger.debug(f"Deleting snapshot {snapshot_name} for VM {self.vm.vm_id}") | ||
| self.qmp_client.command("delvm", **{"name": snapshot_name}) |
There was a problem hiding this comment.
Suggested change
| self.qmp_client.command("delvm", **{"name": snapshot_name}) | |
| self.qmp_client.command("delvm", name=snapshot_name) |
|
|
||
| class QemuSnapshotExecution: | ||
| vm_hash: ItemHash | ||
| execution: any # AlephQemuInstance |
There was a problem hiding this comment.
Suggested change
| execution: any # AlephQemuInstance | |
| execution: Any # AlephQemuInstance |
This should be Any from typing, I'm surprised this worked
|
|
||
| async def start(self) -> None: | ||
| logger.debug(f"Starting QEMU snapshots for VM {self.vm_hash} every {self.frequency} minutes") | ||
| job = self._scheduler.every(self.frequency).minutes.do(run_threaded_snapshot, self.execution) |
There was a problem hiding this comment.
Suggested change
| job = self._scheduler.every(self.frequency).minutes.do(run_threaded_snapshot, self.execution) | |
| self._job = self._scheduler.every(self.frequency).minutes.do(run_threaded_snapshot, self.execution) |
And remove the next line
|
|
||
| async def start(self) -> None: | ||
| logger.debug(f"Starting QEMU snapshots for VM {self.vm_hash} every {self.frequency} minutes") | ||
| job = self._scheduler.every(self.frequency).minutes.do(run_threaded_snapshot, self.execution) |
There was a problem hiding this comment.
Suggested change
| job = self._scheduler.every(self.frequency).minutes.do(run_threaded_snapshot, self.execution) | |
| self._job = self._scheduler.every(self.frequency).minutes.do(run_threaded_snapshot, self.execution) |
And remove the next line
| await snapshot_execution.stop() | ||
|
|
||
| async def stop_all(self) -> None: | ||
| await asyncio.gather(*(self.stop_for(vm_hash) for vm_hash in list(self.executions.keys()))) |
There was a problem hiding this comment.
Shouldn't this function also do a job_thread.stop()? I'm no sure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create automatic Qemu snapshots every 10 minutes
Related ClickUp, GitHub or Jira tickets : ALEPH-XXX
Self proofreading checklist
packaging/MakefileChanges
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]
How to test
Check if a snapshot is created every 10 minutes