Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage system: remove reserved usage from sparse file (disk not used) #780

Closed
wants to merge 1 commit into from

Conversation

olethanh
Copy link
Collaborator

to calcule available disk space

This will help the scheduler scheduler more properly the available resource on CRNs

Related ClickUp, GitHub or Jira tickets : Jira: ALEPH-420

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.
  • Dependencies update in the project.toml have been mirrored in the Debian package build script packaging/Makefile

to calcule available disk space

This will help the scheduler scheduler more properly the available resource on CRN

Jira: ALEPH-420
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 74.41860% with 11 lines in your changes missing coverage. Please review.

Project coverage is 63.34%. Comparing base (f09bdd2) to head (a1d1f39).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/aleph/vm/utils/sparse_disk_space.py 75.60% 9 Missing and 1 partial ⚠️
src/aleph/vm/orchestrator/views/authentication.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #780      +/-   ##
==========================================
+ Coverage   63.26%   63.34%   +0.07%     
==========================================
  Files          77       78       +1     
  Lines        6855     6897      +42     
  Branches      576      580       +4     
==========================================
+ Hits         4337     4369      +32     
- Misses       2329     2338       +9     
- Partials      189      190       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

olethanh added a commit that referenced this pull request Mar 24, 2025
of vm when calculate available disk space

Jira: ALEPH-420

This will help the scheduler scheduler more properly the available resource on CRN

Alternative approach to #780 as Sparse file were not properly created.
@olethanh
Copy link
Collaborator Author

supserssed by #784

@olethanh olethanh closed this Mar 27, 2025
nesitor pushed a commit that referenced this pull request Mar 31, 2025
of vm when calculate available disk space

Jira: ALEPH-420

This will help the scheduler scheduler more properly the available resource on CRN

Alternative approach to #780 as Sparse file were not properly created.
olethanh added a commit that referenced this pull request Mar 31, 2025
of vm when calculate available disk space

Jira: ALEPH-420

This will help the scheduler scheduler more properly the available resource on CRN

Alternative approach to #780 as Sparse file were not properly created.
olethanh added a commit that referenced this pull request Mar 31, 2025
of vm when calculate available disk space

Jira: ALEPH-420

This will help the scheduler scheduler more properly the available resource on CRN

Alternative approach to #780 as Sparse file were not properly created.
olethanh added a commit that referenced this pull request Mar 31, 2025
of vm when calculate available disk space

Jira: ALEPH-420

This will help the scheduler scheduler more properly the available resource on CRN

Alternative approach to #780 as Sparse file were not properly created.
olethanh added a commit that referenced this pull request Mar 31, 2025
of vm when calculate available disk space

Jira: ALEPH-420

This will help the scheduler scheduler more properly the available resource on CRN

Alternative approach to #780 as Sparse file were not properly created.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant