Ensure transaction inputs return complete output data #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a rare edge case when querying transactions that have just been inserted, but whose inputs have not yet been updated by `InputUpdateQueries`. In this scenario, the API returns the transactions, but the inputs are missing output data such as address and amount. This makes it difficult for applications to process these transactions. To address this, the API should only return transactions with complete data. For this edge case (which typically lasts around 300ms between insert and update), when querying transactions, we check if input data is complete—which is almost always the case. If not, we retrieve the corresponding output so users always receive complete transaction data. If for some reason we can't find the output, we'll return then incomplete input.
h0ngcha0
reviewed
Sep 8, 2025
| outputRefAmount = Some(output.amount), | ||
| outputRefTokens = output.tokens | ||
| ) | ||
| case None => input |
There was a problem hiding this comment.
Q: Is it possible that we end up in this situation where input still dose not have complete data?
There was a problem hiding this comment.
It's very very unlikely, I don't see yet a case, but there's always that one edge case we don't see :)
| * If not, we get back outputs for the missing inputs | ||
| */ | ||
| def validateInputFromTx( | ||
| input: InputsFromTxQR |
There was a problem hiding this comment.
[Nit] Shall we call it InputFromTxQR and InputQR?
There was a problem hiding this comment.
yes would make more sense indeed, I think the reasoning was: Query Response of Inputs table, but as the type represent only 1 input, it would be better
There was a problem hiding this comment.
@h0ngcha0 I also renamed some other types not used here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a rare edge case when querying transactions that have just been inserted, but whose inputs have not yet been updated by
InputUpdateQueries. In this scenario, the API returns the transactions, but the inputs are missing output data such as address and amount. This makes it difficult for applications to process these transactions.To address this, the API should only return transactions with complete data. For this edge case (which typically lasts around 300ms between insert and update), when querying transactions, we check if input data is complete—which is almost always the case. If not, we retrieve the corresponding output so users always receive complete transaction data.
If for some reason we can't find the output, we'll return then incomplete input.