Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vscode marketplace link #281

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Add vscode marketplace link #281

merged 3 commits into from
Aug 29, 2024

Conversation

simerplaha
Copy link
Member

Keeps the second commit from PR #238.

@simerplaha simerplaha requested a review from tdroxler August 28, 2024 02:40
tdroxler
tdroxler approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@tdroxler tdroxler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Could you maybe also add in the README that java is required to run ralph-lsp?

Some users were confused why it was not working, but they haven't java installed on their machine.

@simerplaha simerplaha merged commit 2d7933f into master Aug 29, 2024
3 checks passed
@simerplaha simerplaha deleted the restore_doc branch August 29, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdroxler tdroxler tdroxler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simerplaha @tdroxler