Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/various fixes #321

Merged
merged 23 commits into from
Sep 9, 2024
Merged

Feat/various fixes #321

merged 23 commits into from
Sep 9, 2024

Conversation

HectorxH
Copy link
Contributor

@HectorxH HectorxH commented Sep 3, 2024

Summary of the changes

  • Improved error handling
  • Improved run_dev.py script to run all of the APIs
  • Moved object js code to its own file
  • Added support for ESLint and Prettier
  • Ran Black, Ruff and Isort for python code and ESLint and Prettier for JS and CSS
  • Limited the number of decimals for RA and DEC in the Object card

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.30%. Comparing base (df3af6d) to head (0678e5e).
Report is 972 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (df3af6d) and HEAD (0678e5e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (df3af6d) HEAD (0678e5e)
unittests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #321       +/-   ##
===========================================
- Coverage   91.21%   67.30%   -23.91%     
===========================================
  Files          41       21       -20     
  Lines        1002      988       -14     
===========================================
- Hits          914      665      -249     
- Misses         88      323      +235     
Flag Coverage Δ
unittest 67.30% <100.00%> (?)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ClaudioMansillaB ClaudioMansillaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HectorxH HectorxH merged commit a8014f4 into main Sep 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants