Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect prop changes for on[Delete/Update/Edited] callbacks #186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DennisNissen
Copy link

EditControl silently makes onDelete, onEdited and onCreated immutable by passing the initial value to the Control Component, but not updating it when they change.

This could lead (or it did in my project) to imcomprehensible problems.

By adding the callback properties to the useEffect function that creates the control, this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant