respect prop changes for on[Delete/Update/Edited] callbacks #186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EditControl
silently makesonDelete
,onEdited
andonCreated
immutable by passing the initial value to the Control Component, but not updating it when they change.This could lead (or it did in my project) to imcomprehensible problems.
By adding the callback properties to the
useEffect
function that creates the control, this is fixed.