This repository has been archived by the owner on Jan 16, 2024. It is now read-only.
Adds rewind function to allow curl seek and retry sending data to server #1529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
ACSDK_EMIT_SENSITIVE_LOGS
to output curl error messages and me help investigate what was going on"necessary data rewind wasn't possible"
:CURLOPT_SEEKFUNCTION
and settingCURLOPT_SEEKDATA
will solve this problemAttachmentReader
already has a seek function which mirrors the implementation ofCURLOPT_SEEKFUNCTION
: Both expect to be able to set the absolute index of the buffer instead of changing the cursor by some delta.Description of changes:
CURLOPT_SEEKFUNCTION
rewind
function to the read callbacksseek
onAttachmentReader
when called from curlTesting:
Was able to build and run automated tests. This seems to fix the issue. No more 56 or 65 errors.