Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/golangci/golangci-lint from 1.57.2 to 1.59.1 in /tools #79

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ linters-settings:
disable-dec-order-check: false
disable-init-func-first-check: false
gci:
local-prefixes: github.com/alexandear/import-gitlab-commits
sections:
- standard
- default
- prefix(github.com/alexandear/import-gitlab-commits)
goconst:
min-len: 2
min-occurrences: 2
Expand Down Expand Up @@ -48,21 +51,11 @@ linters:
enable-all: true
disable:
- depguard
- maligned
- exhaustivestruct
- exhaustruct
- err113
- nonamedreturns
- gomnd
- nosnakecase
- interfacer
- varcheck
- ifshort
- structcheck
- deadcode
- scopelint
- golint
- rowserrcheck
- wastedassign
- goerr113
- paralleltest
- testpackage
4 changes: 3 additions & 1 deletion internal/gitlab.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,11 @@ func (s *GitLab) FetchCommits(ctx context.Context, user *User, projectID int, si
) ([]*Commit, error) {
commits := make([]*Commit, 0, maxCommits)

const commitsPerPage = 100

page := 1
for page > 0 {
cms, nextPage, err := s.fetchCommitPage(ctx, user, page, 100, since, projectID)
cms, nextPage, err := s.fetchCommitPage(ctx, user, page, commitsPerPage, since, projectID)
if err != nil {
return nil, fmt.Errorf("fetch one commit page: %w", err)
}
Expand Down
2 changes: 1 addition & 1 deletion tools/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ module github.com/alexandear/import-gitlab-commits/tools

go 1.22

require github.com/golangci/golangci-lint v1.57.2
require github.com/golangci/golangci-lint v1.59.1
4 changes: 2 additions & 2 deletions tools/go.sum
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
github.com/golangci/golangci-lint v1.57.2 h1:NNhxfZyL5He1WWDrIvl1a4n5bvWZBcgAqBwlJAAgLTw=
github.com/golangci/golangci-lint v1.57.2/go.mod h1:ApiG3S3Ca23QyfGp5BmsorTiVxJpr5jGiNS0BkdSidg=
github.com/golangci/golangci-lint v1.59.1 h1:CRRLu1JbhK5avLABFJ/OHVSQ0Ie5c4ulsOId1h3TTks=
github.com/golangci/golangci-lint v1.59.1/go.mod h1:jX5Oif4C7P0j9++YB2MMJmoNrb01NJ8ITqKWNLewThg=