jsonata expression evaluation is async, so needs to be awaited#11
Merged
Alkarex merged 2 commits intoalexandrainst:masterfrom Feb 8, 2023
Merged
jsonata expression evaluation is async, so needs to be awaited#11Alkarex merged 2 commits intoalexandrainst:masterfrom
Alkarex merged 2 commits intoalexandrainst:masterfrom
Conversation
Member
|
Thanks for the bug report and PR 👍🏻 |
Member
|
@jamiepenney New version published. Could you please give it a try? |
Contributor
Author
|
Works perfectly, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/jsonata-js/jsonata/blob/master/CHANGELOG.md#200-major-release
It looks like version 2.0 of the
jsonatapackage changedexpression.evaluateto return a promise, so thematchobject was never matching an actual case fromcases. You can see the change they made in their quick start docs here: https://github.com/jsonata-js/jsonata#quick-startI haven't checked the rest of this codebase for any other problems like this, as I am only using the resolver with JSOnata and validator nodes with JSON Schema.