Skip to content

feat: add log attr#69

Open
94noni wants to merge 1 commit into
alexandre-daubois:mainfrom
94noni:log-attr
Open

feat: add log attr#69
94noni wants to merge 1 commit into
alexandre-daubois:mainfrom
94noni:log-attr

Conversation

@94noni

@94noni 94noni commented May 11, 2026

Copy link
Copy Markdown
Contributor

👋🏻
according to https://github.com/php/frankenphp/blob/68573a9b640a679cbf420169cdbb960317c6db16/scaling.go#L142
some log may have attributes


I would like to display them on the ember tui, to have a direct vision of such data

Capture d’écran 2026-05-11 à 11 21 27

ℹ️ untested for now, just opening as reflexion/discussion

@alexandre-daubois

Copy link
Copy Markdown
Owner

Thank you for proposing!

Good idea on principle: runtime logs carry useful diagnostic info we currently drop. My only doubt is the UX: appending [k=v k=v] inside an already-truncated message column will get noisy fast on logs with 4+ attributes. Worth considering a detail pane on row selection instead, keeping the inline suffix only as a compact fallback maybe!

@94noni

94noni commented May 11, 2026

Copy link
Copy Markdown
Contributor Author

that is an option indeed, a right panel on log line detail
I will think about it :)
thx for stoping by

@94noni

94noni commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

@alexandre-daubois I took some time to redo/rewrite this PR (bootstrapped with ia a bit)
now there is a panel registered on logs (not routes aggregations) and displaying those attributes metadata, to avoid having to display those kv pairs on the default table, keeping it clean by default

Capture d’écran 2026-05-13 à 19 29 32 Capture d’écran 2026-05-13 à 19 35 53

would this be ok for you? so I can polish/finish this behavior
thx

Comment thread local/frankenphp/Makefile
.DEFAULT_GOAL := help

.PHONY: local clean help
.PHONY: local up down traffic

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably a miss rewrite from my original makefile ;)

Comment thread internal/ui/logs.go
{"←/→", "panel"},
{"/", "filter"},
}
if !routesView {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

routesViews are aggregated so no unitary metadata

@alexandre-daubois

Copy link
Copy Markdown
Owner

would this be ok for you? so I can polish/finish this behavior

Let's go for it! Tell me when it's ready for review 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants