Run miri test with --features global in ci#52
Open
MortenLohne wants to merge 2 commits intoalexcrichton:mainfrom
Open
Run miri test with --features global in ci#52MortenLohne wants to merge 2 commits intoalexcrichton:mainfrom
--features global in ci#52MortenLohne wants to merge 2 commits intoalexcrichton:mainfrom
Conversation
… global)]' If testing without --target global, the tests would run and succeed, but not actually use the allocator's code. This behavior makes it more obvious that you're doing something wrong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5/8 tests in this repository use the global allocator, making them ineffective without
--features global. The miri tests in CI were unfortunately run without this flag, and they show UB if run properly, see #51.This PR also completely feature-gates the global tests behind the
globalfeature, since they are basically no-ops without it. This should help avoid similar mistakes in the future.