Fix bug in FullLaplace.sample (refer to Issue #268)#270
Merged
wiseodd merged 1 commit intoaleximmer:mainfrom Feb 1, 2025
Merged
Fix bug in FullLaplace.sample (refer to Issue #268)#270wiseodd merged 1 commit intoaleximmer:mainfrom
FullLaplace.sample (refer to Issue #268)#270wiseodd merged 1 commit intoaleximmer:mainfrom
Conversation
Owner
|
Thanks a lot for spotting and fixing this bug! @wiseodd, do you know why ruff is failing? |
aleximmer
approved these changes
Jan 19, 2025
Collaborator
|
Ruff is failing because some files are not formatted using ruff. It's trivial to fix but I can't push my change to this PR. Will merge and immediately push the fix to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in the full$samples @ scale \rightarrow samples @ scale^{\top}$ which coincides with the remaining code. The bug is discussed in Issue #268.
FullLaplace.samplefunction, by changing