fix(tui): fixed shell completion widget not rendering, add poc for fish

[lalvarezt]

solves #586

[lalvarezt]

waiting for #589

[lalvarezt]

@alexpasmantier please have a look, makes the shell_integration usable with a partial height

EDIT: unfortunately we have to make this dance because crossterm Inline is a second class citizen, perhaps it will improve in the future.

[alexpasmantier]

@lalvarezt Found a working solution cbf50dd

Side note: Also figured that updating this makes the UX a bit nicer for zsh.

Would you mind giving this a try and telling me if it works as expected on your machine?

[lalvarezt]

oh nice 👏, but I'm seeing this weird new line again (in fish), specifically when right at the bottom of the screen

And this in zsh

on   ➜ zsh
FedoraLinux42-wsl% source ./television/utils/shell/completion.zsh
FedoraLinux42-wsl% nvim
Error: The cursor position could not be read within a normal duration
FedoraLinux42-wsl% nvim $'\033'\[6n

[lalvarezt]

made the resizing a much simpler implementation, yes we lose the context from the shell previous commands but being honest while resizing it's not a big deal, IMO
This way it works just as the full screen version and we don't have to manually adjust for every situation

[alexpasmantier]

For the cursor position error:

Are you sure you're recompiling the release binary ? Because that's what's being used by the shell script.

[alexpasmantier]

Regarding resizing:

Was the actual implementation broken? I don't feel we gain that much simplicity by dropping the feature so might as well keep it if it's working as intended.

[lalvarezt]

For the cursor position error:

Are you sure you're recompiling the release binary ? Because that's what's being used by the shell script.

I patched the zsh file to use the actual implementation, yes

Edit: as you can see I don't use zsh anymore so this just the plain installation with nothing else in it

Edit 2: there's also the thing of the passthrough escape code. For some reason is not being processed

[lalvarezt]

Regarding resizing:

Was the actual implementation broken? I don't feel we gain that much simplicity by dropping the feature so might as well keep it if it's working as intended.

Yes I'm seeing virtual artifacts. Not sure if that's visible with asciinema. You can try on your side to replicate, open a new terminal session with the screen cleared (the term emulator not in full-screen), open tv --height 20, then horizontally expand. The lines above the prompt get mangled. If you expand vertically (expand) works ok from what I've seen.

Edit: I'm using Wezterm nightly

[alexpasmantier]

Screencast.From.2025-07-06.11-58-23.mp4

I'm getting the extra line too (will take a look at why that's happening), but the --inline is working as expected with the zsh shell integration.

[alexpasmantier]

There's also a bug in the zsh script where leaving tv without selecting anything still introduces an empty completion item

[lalvarezt]

There's also a bug in the zsh script where leaving tv without selecting anything still introduces an empty completion item

interesting, for in zsh, I don't get the neither the newlines (not even close to the bottom edge) nor the empty selection

television.mp4

[alexpasmantier]

Ah okay, same here, nevermind might have gotten mixed up 👍🏻

So in the current state of things I believe everything is working as intended right?

The only minor thing left to do being to figure out how to keep the current prompt when using --inline without having the newline issue.

[lalvarezt]

@alexpasmantier pushed some tweaks, seem to work on my side in all conditions, can you please check

[alexpasmantier]

@lalvarezt works perfectly on my side 🎉

(except for the fact that tv overwrites the prompt which isn't the best UX)

Screencast.From.2025-07-06.16-03-02.mp4

[lalvarezt]

@lalvarezt works perfectly on my side 🎉

(except for the fact that tv overwrites the prompt which isn't the best UX)

Screencast.From.2025-07-06.16-03-02.mp4

Ah, yes. Since I use a two line prompt I didn't think too much about it. I'll have a look later

[alexpasmantier]

Let's merge this then, good job that was a tough one 👍🏻