Add brushless hardware support #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
alexrudd2
force-pushed
the
brushless-v5
branch
from
a981e1d to
4791eaf
Compare
jedahan
reviewed
Oct 16, 2023
jedahan
approved these changes
Oct 16, 2023
Co-authored-by: Jonathan Dahan <[email protected]>
Thanks for refactoring my garbage POC code :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #94. Closes nornagon#136
@jedahan's code adds support for the brushless servo upgrade, which uses a different pinout on the EBB.
The hardware can be selected with a new CLI option:
--hardware v3is the default brushed motor--hardware brushlessis the brushless servo.This can also be selected with a checkbox in the GUI.
The brushless motor is more powerful and slams the pen all the way to the limit stop upon cancellation. For now move to 50%.