-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📐 formatting rules #153
📐 formatting rules #153
Conversation
Fine with me. I don't have strong preferences for TypeScript anyways. Well actually, I had been considering just switching to Biome. eslint and its plugins seem to break compatibility a lot What's been keeping me from doing any type of formatting changes is a desire to keep in sync with upstream, but it's becoming more and more likely that it's just abandoned. I'll reach out again. |
@alexrudd2 are there downstream changes we can adopt? |
There have generally been two contributors of interest. Here's the project where I tried to track upstreaming changes: https://github.com/users/alexrudd2/projects/1 |
I've emailed @jedahan re: the state of saxi upstream. Let's see what he says. |
I am happy to adopt any automated tooling like formatters, and if i need to re-create/submit/fix features can do so now that I have my plotter back at home. If we are okay with larger divergence in some longer-term future, I've started things like writing some typescript apis for interfacing with EBB commands |
I see this fork as the experimental cousin of upstream, so if we think formatting is good, its good to try here first, and then show upstream and hope they see the benefits too. |
@jedahan As of now this is now the main development repository. I released |
Added https://eslint.style/packages/default stylistic plugin for formatting, and enabled a few rules:
I want to enable always semicolon, in general is an excellent rule (some bugs are harder to spot due to lack of semicolons), I'll let you decide.