Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📐 formatting rules #153

Merged
merged 5 commits into from
Jan 20, 2025
Merged

📐 formatting rules #153

merged 5 commits into from
Jan 20, 2025

Conversation

juli4nb4dillo
Copy link
Collaborator

Added https://eslint.style/packages/default stylistic plugin for formatting, and enabled a few rules:

  • Consistent indent to 2 spaces
  • Space infix operators
  • Space on curly brackets for objects.

I want to enable always semicolon, in general is an excellent rule (some bugs are harder to spot due to lack of semicolons), I'll let you decide.

@juli4nb4dillo juli4nb4dillo changed the title :rule: formatting rules 📐 formatting rules Nov 17, 2024
@alexrudd2
Copy link
Owner

I want to enable always semicolon, in general is an excellent rule (some bugs are harder to spot due to lack of semicolons), I'll let you decide.

Fine with me. I don't have strong preferences for TypeScript anyways. Well actually, I had been considering just switching to Biome. eslint and its plugins seem to break compatibility a lot

What's been keeping me from doing any type of formatting changes is a desire to keep in sync with upstream, but it's becoming more and more likely that it's just abandoned. I'll reach out again.

@juli4nb4dillo
Copy link
Collaborator Author

@alexrudd2 are there downstream changes we can adopt?

@alexrudd2
Copy link
Owner

@alexrudd2 are there downstream changes we can adopt?

There have generally been two contributors of interest.
@jedahan knows about this fork, and helped implement the brushless mode (note: it's not fully working). We've got contact via email.
@osresearch pops up every now and then with PR's to saxi upstream. (example: nornagon#213). I pay attention, but haven't established contact.

Here's the project where I tried to track upstreaming changes: https://github.com/users/alexrudd2/projects/1

@alexrudd2
Copy link
Owner

I've emailed @jedahan re: the state of saxi upstream. Let's see what he says.

@jedahan
Copy link
Collaborator

jedahan commented Nov 21, 2024

I am happy to adopt any automated tooling like formatters, and if i need to re-create/submit/fix features can do so now that I have my plotter back at home.

If we are okay with larger divergence in some longer-term future, I've started things like writing some typescript apis for interfacing with EBB commands

@jedahan
Copy link
Collaborator

jedahan commented Nov 21, 2024

I see this fork as the experimental cousin of upstream, so if we think formatting is good, its good to try here first, and then show upstream and hope they see the benefits too.

@alexrudd2
Copy link
Owner

I see this fork as the experimental cousin of upstream, so if we think formatting is good, its good to try here first, and then show upstream and hope they see the benefits too.

@jedahan As of now this is now the main development repository. I released 0.16.0 last night, so let's go for the other changes now :)

@alexrudd2 alexrudd2 merged commit 5bbd0e9 into main Jan 20, 2025
6 checks passed
@alexrudd2 alexrudd2 deleted the formatting-rules branch January 20, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants