Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shelly1 as GarageDoorOpener - actually Garage Door Switch #239

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

MichaelVdheeren
Copy link

No description provided.

@MichaelVdheeren
Copy link
Author

See also #121

@apartmedia
Copy link

Is this being merged in the next release or not?
Does it only work with a Reed Sensor connected to Shelly1 SW input or also by using the Shelly1 Addon (with the Reed Sensor connected to their black and yellow wire, which is a relatively new feature from Shelly)?

@MichaelVdheeren
Copy link
Author

This currently only works with the Shelly 1 switch input. Don't have a Shelly1 Addon, so unable to try, but think it's easy to adapt.

@apartmedia
Copy link

Would it help to get you an Addon for testing or is this type of code extension of no interest for you?
Beside all that: Your current PR has not been merged in the latest plugin version 0.16.0 by @alexryd yet, right?

@MichaelVdheeren
Copy link
Author

@apartmedia yes that would help me of course and I am happy to spend some time on it. Indeed the current PR has not been merged in into the latest version.

Copy link
Owner

@alexryd alexryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MichaelVdheeren! I have a few comments, otherwise LGTM!

abilities/garage-door-switch.js Show resolved Hide resolved
abilities/garage-door-switch.js Outdated Show resolved Hide resolved
abilities/garage-door-switch.js Outdated Show resolved Hide resolved
abilities/garage-door-switch.js Outdated Show resolved Hide resolved
accessories/garage-door-openers.js Outdated Show resolved Hide resolved
abilities/garage-door-switch.js Outdated Show resolved Hide resolved
@MichaelVdheeren
Copy link
Author

@alexryd thanks for the feedback, will run over the requests during the weekend - also will add to the README as part of this pull request.

@alexryd
Copy link
Owner

alexryd commented Jan 13, 2021

👍

@tivo65
Copy link

tivo65 commented Feb 4, 2021

would this feature give visibility to the external switch add-on state? I use a reed sensor on my garage door, it shows open in the shelly app with the vertical line on the button. it would be great to see the state of the reed sensor through hoobs.

@apartmedia
Copy link

@MichaelVdheeren Could you manage to work on alexryd request regarding your door opener code?
Are there any time plans to integrate this into the plugin?
If the current functionality is being made available for usage in this plugin I can get you an Addon for further development and testing if you like and still interested.

@ToppScorer
Copy link

Would also like to see this feature merged in

@MichaelVdheeren
Copy link
Author

Should be all done. Know some further improvements I can work on to include the STOPPED state but that needs some more work.

@fritte87
Copy link

fritte87 commented Sep 2, 2021

Hi, is it Possible to make the Shelly1 as type "GarageDoorOpener"? like in Shelly 2.5 ??

@rjvq85
Copy link

rjvq85 commented Jan 24, 2023

Can this be merged? Thanks

@cefoster0
Copy link

cefoster0 commented Dec 5, 2023

would be so great if this could be merged. I created a local repo and merged it with master to test.

@cefoster0
Copy link

@MichaelVdheeren
I know this is an old pull request, but In my testing I found line 114 on garage-door-switch.js to be a problem. Its sending 'true' rather then the new value, so the shelly1 would never close its switch. it just always stays open. I changed it to 'newValue' in my copy and now the shelly opens and closes with HomeKit, emulating what the shelly app does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants