fix for multiple custom queries #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check to see if queries is a property of the urlOptions object, before deleting the current input from the query. Without this check, the script was throwing an Uncaught TypeError: "Cannot convert undefined or null to object" when all the following conditions were met: 1. there is more than one custom queries 2. there is none currently in use 3. the user tries to use any, but the first one found by the selector in the dom (when using the first one found by the selector, the problem doesn't appear). Seems to be related with this issue: #73
|
Merge this please. Tested it myself and it fixes the issue. |
|
+1 |
eddieferrer
added a commit
to eddieferrer/mazamas_climbs
that referenced
this pull request
Jul 11, 2015
…x toggles for grade, fixed small dynatable bug see: alfajango/jquery-dynatable#116
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check to see if queries is a property of the urlOptions object, before
deleting the current input from the query. Without this check, the
script was throwing an Uncaught TypeError: "Cannot convert undefined or
null to object" when all the following conditions were met:
the dom (when using the first one found by the selector, the problem
doesn't appear).
Seems to be related with this issue:
#73