Modifiable processing element #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -787,7 +792,7 @@ | |||
|
|
|||
| this.position = function() { | |||
| var $processing = $('#dynatable-processing-' + obj.element.id), | |||
| $span = $processing.children('span'), | |||
| $span = $processing.find('>:first-child'), | |||
There was a problem hiding this comment.
Is this selector change going to cause issues for calculating the total height of the processing indicator, if someone changes the template to be multiple sibling elements on the top level? E.g., if I call dynatable with processingTemplate: '<div>{text}</div><div>Please hold on</div>, this selector will only grab the first div. Maybe we want to change this line to be:
$span = $processing.children()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynatable allows its user to specify a
processingTextwhich is then wrapped inside a<span>. However, span's do not allow block level elements, limiting the possible processing indicators. In particular, I wanted to use SpinKit, which was not possible.This PR adds a
processingTemplatewith the<span>for backwards compatibility. By overwriting theprocessingTemplate, a user can get rid of the span and instead use e.g. SpinKit HTML.