Adds alphanumeric sorting reader option #218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| //extract display text | ||
| a = $(a[attr.toString()]).text(); |
There was a problem hiding this comment.
Drop the toString() on the attr names, since names are always strings anyway regardless of using integers, etc to refer to them.
|
Overall, this functionality looks good, though it's difficult to understand exactly what's going on. If you could comment each of the non-obvious lines to say briefly what they do (or maybe provide an example of Also, fix formatting to be a consistent 2-space indentation throughout the method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little clunkily written, but reliably gets the job done. Any input is welcome!