Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to display "Show x records on a page" #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brandondrew
Copy link

related to issue #56

@mlangens
Copy link

Hi @brandondrew! I'm helping @JangoSteve with Dynatable. We're getting ready to move forward with a lot of overdue work! We're having a meeting about all open PRs next week. We do require that all contributors sign the CLA. Are you available to do so?

@JangoSteve
Copy link
Member

Good point, and that's a great book!

This looks good, except that if not suffix is specified, it still appends a blank span. I'd maybe make the default value null instead of empty string, and then only append the suffix span if present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants