Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only call Array.sort() if sort columns/keys are specified #88

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Only call Array.sort() if sort columns/keys are specified #88

wants to merge 2 commits into from

Conversation

theodorejb
Copy link
Contributor

Fixes issue #87

@JangoSteve
Copy link
Member

Thanks for the pull request. Is this code fixing a specific issue or bug? If so, could you describe what's happening so we know how to test it?

@theodorejb
Copy link
Contributor Author

Yes, this fixes issue #87.

@JangoSteve
Copy link
Member

I'm thinking you might be seeing intended functionality unless I'm mistaken. The default sort function if no sorts are present, is to sort by the original sort order when the data was initialized:

See the originalPlacement sort function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theodorejb @JangoSteve