Create guicesupport module #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wnicholson, are you able to review this one? Otherwise I can assign it elsewhere. |
|
Looks good to me - merging + two tiny tweaks. |
|
This broke builds at Alfa and had to be reverted. The main problem appears to be various builds we have which assume there are JIT bindings in place. This either means that they blow up trying to replace said bindings, or simply assume the default bindings are in place. |
|
This PR is in a merged state so I'll submit a second one at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works towards #14.
Moves the
guicesupportpackage to a new Maven module, and migrates the JIT bindings forSqlScriptExecutorandTableLoaderBuilderto there, removing@Injectand@ImplementedBy.This is broadly the same pattern we will follow to remove the Guice stuff elsewhere (effectively, change everything to Dagger style bindings). Will hack away at those as a series of future PRs.