Fix RIDs bug on updating non-simulcast media #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On updating media via SDP (e.g. direction switch), the claimed RX/TX RIDs was being unintentionally changed from Rids::Any/Rids::None to Rids::Specific with an empty RIDs array. This fix prevents that.
algesten
approved these changes
Jan 16, 2025
|
Let's land it. There's a bigger question here about the semantic meaning of Rids
I think I introduced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #611
425a851 added a
Fromimpl that converted from a slice of RIDs into aRidsinstance, and unconditionally used it when updating media via SDP. However, this impl did not take into account empty slices, which are naturally produced when simulcast is not in play. This caused non-simulcast tracks to start reportingRids::Specific(vec![])once they were updated by e.g. a direction change.As the correct
Ridsvalue on an empty slice depends on whether you're sending or receiving, this PR removes theFromimpl entirely and replaces it with manual conversion while updating media via SDP.