feat!: support new algoliasearch and django versions #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
changed the title
shortcuts
commented
Nov 27, 2024
| self.__index.partial_update_objects(batch) | ||
| batch = [] | ||
|
|
||
| # TODO: pass batch_size to partial_update_objects |
There was a problem hiding this comment.
ah yes I need to support that
| algoliasearch>=3.0,<4.0 | ||
| Django>=4.0 | ||
| # algoliasearch>=4.0,<5.0 | ||
| algoliasearch @ git+https://github.com/algolia/algoliasearch-client-python@main |
There was a problem hiding this comment.
waiting for bfcm to end for this
millotp
reviewed
Nov 27, 2024
|
|
||
| [testenv:lint] | ||
| deps = | ||
| ruff {[versions]ruff} |
| Website.objects.create(name='Facebook', url='https://www.facebook.com') | ||
| Website.objects.create(name='Facebook', url='https://www.facebook.fr') | ||
| Website.objects.create(name='Facebook', url='https://fb.com') | ||
| Website(name="Algolia", url="https://www.algolia.com", is_online=False) |
There was a problem hiding this comment.
can you configure ruff to use single quote as before ? or you prefer double quotes ?
There was a problem hiding this comment.
I went with the default configuration just to have simpler maintenance logic but... I don't really mind
| algoliasearch>=3.0,<4.0 | ||
| Django>=4.0 | ||
| # algoliasearch>=4.0,<5.0 | ||
| algoliasearch @ git+https://github.com/algolia/algoliasearch-client-python@main |
There was a problem hiding this comment.
this will need to change when released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3186 https://algolia.atlassian.net/browse/DI-3187 https://algolia.atlassian.net/browse/DI-3188 https://algolia.atlassian.net/browse/DI-3189 https://algolia.atlassian.net/browse/DI-3191
Changes included:
upgrade the package to support django v4 and v5, also upgrade the algoliasearch client
List of breaking changes:
clear_index, useclear_objectsinstead