Update ProductHelper.php to prevent false in facets #1537
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a report from a customer that their facets show false as a value because there is no check if the value is false before passing it on to be potentially added to the facet. Adding their suggestion which should resolve the issue.
|
Thanks to https://github.com/markfischmann for suggesting this change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a report from a customer that their facets show false as a value because there is no check if the product attribute value is false before passing it on to be potentially added to the attributes of a product. Adding their suggestion which should resolve the issue.
Summary
This change modifies the check to make sure that the attribute value is not false before passing it to the $customerData object
Result