MAGE-1319 Refactor for backend search client support #1850
Conversation
| * | ||
| * @throws NoSuchEntityException | ||
| */ | ||
| protected function safeBuildWithComputedIndex(string $indexSuffix, int $storeId, bool $isTmp = false): IndexOptionsInterface |
There was a problem hiding this comment.
If there a particular reason not to simply replace buildWithComputedIndex by this implementation on the parent class ?
The Index Options management begins to be quite complex and I'm wondering if it's necessary
There was a problem hiding this comment.
I agree! The only reason I didn't do this was because we made the API allow for an optional $indexSuffix. If any one has customized the connector it might break their code. But it's a fairly new class and we didn't provide an API interface contract for it so we could just pull the trigger there. WDYT?
There was a problem hiding this comment.
I would be really surprised if anyone has already customized this indeed 😆
I'm not sure what you mean by "pull the trigger there" 🤔
There was a problem hiding this comment.
Pardonne-moi mon expression idiomatique anglaise!
It means to "commit to something" / "go through with it" - or in this case like a pulling the trigger on a firearm I'm going to kill this unnecessary abstract class. 😂
There was a problem hiding this comment.
ahah thanks for the clarification 😆
Summary
The PR provides support for extension via the search adapter:
IndexOptionsBuilderwith improved error handlingAlgoliaConnectorAlgoliaHelperhas been removedResult
Updated logging:
Fixed integration test:
IndexOptionsBuilder unit tests:
