Skip to content

Conversation

@raed667
Copy link
Contributor

@raed667 raed667 commented Sep 24, 2025

Summary

fallbackParameters shouldn't be passed to the query unless the user specifically provides a value. Otherwise this could trigger an unexpected fallback query.

@raed667 raed667 requested a review from Haroenv September 24, 2025 14:18
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8cd9f34:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems correct, thanks! I'll merge this after the chat + autocomplete is merged and released, so this can be a separate change, ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants