feat(instantsearch.js): introduce autocomplete widget #6759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bb9621b:
|
shaejaz
approved these changes
Oct 27, 2025
| import { | ||
| connectAutocomplete, | ||
| connectSearchBox, | ||
| } from '../../connectors/index.umd'; |
There was a problem hiding this comment.
Yes, it prevents us from importing the chat, so rollup can properly bundle the UMD package.
Comment on lines
+33
to
+41
| type CreateAutocompletePropGettersParams = { | ||
| useEffect: (effect: () => void, inputs?: readonly unknown[]) => void; | ||
| useId: () => string; | ||
| useMemo: <TType>(factory: () => TType, inputs: readonly unknown[]) => TType; | ||
| useRef: <TType>(initialValue: TType | null) => { current: TType | null }; | ||
| useState: <TType>( | ||
| initialState: TType | ||
| ) => [TType, (newState: TType) => unknown]; | ||
| }; |
There was a problem hiding this comment.
I think in a future PR, we could move these into a shared file. I believe there are some parts of the chat widgets that could use this approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (re-)introduces the
autocomplete()widget, with similar features to Algolia's standalone Autocomplete library.It includes a refactoring of the React implementation to extract the prop getters into a shared module and match the draft JS design in #6745.
FX-3548