ci: 1. added Dockerfile 2. added a workflow on PR #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkrugg
reviewed
Sep 5, 2025
tkrugg
reviewed
Sep 5, 2025
Dockerfile
Outdated
| ENV NODE_ENV=production | ||
|
|
||
| # Default command for production - run the compiled binary | ||
| CMD ["/nodejs/bin/node", "/app/dist/app.js"] No newline at end of file |
There was a problem hiding this comment.
Shouldn't a port be exposed at some point?
There was a problem hiding this comment.
It's not mandatory for the container to function, but will add it if such metadata helps users complete their deployment👍
|
This looks great @yutod thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What
This PR is for CI workflow to build container image.