Fix Travis build #250
Merged
Fix Travis build #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienbourdeau
force-pushed
the
debug/travis
branch
from
f602009
to
c992e71
Compare
julienbourdeau
force-pushed
the
debug/travis
branch
from
c992e71
to
44a198d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
First, Travis wasn't using a different prefix for each build, so all test where using the same indices. Of course, everything failed. I think it's because before, I limited concurrent build to 1, but I probably changed it later and didn't realize it broke.
With PHPUnit < 6, environment variables are not set properly in
$_ENVfor some obscure reason, so I override them insetUp.Doctrine is currently splitting the common package into 3 separate ones, some deprecation notice appeared until we can migrate doctrine/common and keep BC with PHP 5.6 and Symfony 3.4, we allow deprecation notice in PHPUnit.
doctrine/common#826
Note: We could remove tests on 7.0 and 7.1 🤔
What problem is this fixing?
Fix the Travis build 🎉