-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FOR REVIEW ONLY - Release v2.2.0 #753
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add new examples for docs * replace pop()! with element access expressions * fix buffer import * remove JSSDK_ prefix, fix eslint stuff * add missing examples * INDEXER_PREFIX_SEARCH * run format
* Add generated simulation types * Regenerate new models for API spec * Add simulate endpoint implementation * Add simulation endpoint with response * Add basic simulation into composer and add some simple tests * Revert custom ports in cucumber tests * Add simulate tag to tests * Temporarily set testing branch * Regenerate types with added comment for simulate response * Delete unused import * Add back tags * Remove console logging * Change step names * Refactor composer method result parsing and cucumber step wording * Revert one accidental commit * Minor commenting fixes * Change funding account due to keyreg step * Simulate unsigned transactions (#746) * Encode unsigned transactions for simulation * Implement unsigned txn simulate in ATC * Change test branch * Change transaction signer name * Change testing branch * Change funding account due to keyreg transaction * Simple refactoring tests * Revert test changes * Try to fix firefox tests * Fund from initial account * Test cucumber step order * Simplify test * Point branch back to master * Change back steps for firefox * Move back tags * Test another unsigned simulation step * Change back env to master * Change naming of noSig to unsignedSimulate * Update src/client/v2/algod/models/types.ts Co-authored-by: Zeph Grunschlag <[email protected]> * Revert "Update src/client/v2/algod/models/types.ts" This reverts commit 474bbb4. --------- Co-authored-by: Zeph Grunschlag <[email protected]>
Co-authored-by: algochoi <[email protected]>
algobarb
requested review from
jasonpaulos,
algochoi,
excalq,
ahangsu,
bbroder-algo and
onetechnical
and removed request for
jasonpaulos
March 22, 2023 20:00
jasonpaulos
reviewed
Mar 22, 2023
algochoi
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - everything seems to be in here 👍
jasonpaulos
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Bugfixes
Enhancements
New Contributors
Full Changelog: v2.1.0...v2.2.0