-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix template var error handling #310
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(not marking as a fix since it's an unreleased regression & problem with an unreleased feature)
daniel-makerx
approved these changes
Sep 12, 2024
achidlow
force-pushed
the
fix-template-var-error-handling
branch
from
September 12, 2024 12:39
a75ecec
to
799000e
Compare
boolean values are now also allowed as `True` or `False` also incorrect values will no longer result in a critical error, but a CLI usage error instead --------- PuyaOptions now contains a parsed set of key-values for template variables
achidlow
force-pushed
the
fix-template-var-error-handling
branch
from
September 13, 2024 01:35
799000e
to
f23b742
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puyapy
fixes:True
orFalse
puya
changes:PuyaOptions
now contains a parsed set of key-values for template variablesfixes for both: