Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding proxy logic #7

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

GrandNative
Copy link

hi Ali, I am Morteza, I came across this package for one of my projects, for some reason I could not use this package, however, I noticed that you did not consider any logic to use a proxy while Telethon provided this possibility. That's why I decided to add this logic, anyway, you know how difficult life is in Iran :)
I tried to add this feature very simply and with the least number of lines.
I have another way to do this, which is to use a database and consider a table for the proxy. If you like, we can talk more about this way.
This is my first contribution to an open-source project, so if you see a problem in my work, please let me know.
and my Telegram ID, in case you want to contact me: @M_grand

@ali-zahedi
Copy link
Owner

Hi @GrandNative,

Thank you for your contribution and for suggesting proxy support! Your approach is appreciated, especially considering the challenges you've outlined. It's great to see new contributors bringing valuable features to the table.

I'm interested in hearing more about your database idea for proxy management. It sounds like it could provide a flexible solution for users. does each connection use its own proxy, is there a random selection process, or is it a global setting that can override per connection? WDYT?

For now, the solution you've proposed seems solid. Could you please ensure the README is updated to reflect how the proxy support works? This information will be crucial for users to understand how to utilize the feature based on their needs.

Looking forward to discussing your ideas further.

Best,
Ali

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants