fix bazel OOM problems #1034
Open
fix bazel OOM problems #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyzero
reviewed
Feb 22, 2023
tensorflow_blade/.bazelrc
Outdated
| @@ -69,6 +69,8 @@ build:disc_aarch64 --cxxopt=-DTAO_AARCH64 | |||
| build:disc_aarch64 --define disc_aarch64=true | |||
| build:disc_aarch64 --linkopt="-Xlinker --stub-group-size -Xlinker 10000000" | |||
| build:disc_aarch64 --action_env BUILD_WITH_AARCH64=1 | |||
| build:disc_aarch64 --experimental_local_memory_estimate | |||
| build:disc_aarch64 --jobs=10 | |||
There was a problem hiding this comment.
is 10 too small for parallelism? @qiuxiafei @Yancey1989
There was a problem hiding this comment.
what about determining this number according to the number of the cores on the machine
There was a problem hiding this comment.
Yes, 10 is usually to small. And as on different machines, number of cores varies, there won't be a fit-for-all number. How about --local_cpu_resources/--local_ram_resources here: https://bazel.build/docs/user-manual#local-resources
qiuxiafei
reviewed
May 18, 2023
| @@ -37,7 +37,7 @@ build:disc --config=release_base | |||
|
|
|||
| build:disc_cpu --config=disc --cxxopt=-DTAO_CPU_ONLY | |||
| build:disc_x86 --config=disc_cpu --config=release_cpu_linux --cxxopt=-DTAO_X86 --define disc_x86=true | |||
| build:disc_aarch64 --config=disc_cpu --cxxopt=-DTAO_AARCH64 --define disc_aarch64=true --linkopt="-Xlinker --stub-group-size -Xlinker 10000000" | |||
| build:disc_aarch64 --config=disc_cpu --cxxopt=-DTAO_AARCH64 --define disc_aarch64=true --linkopt="-Xlinker --stub-group-size -Xlinker 10000000" --experimental_local_memory_estimate --local_ram_resources=HOST_RAM*.5 --local_cpu_resources=HOST_CPUS*.5 | |||
There was a problem hiding this comment.
Could be more aggressive? How about 80% of RAM and 90% of CPU
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.