Skip to content

fix: allow label conversion from null value #4629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shirly121 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: allow label conversion from null value #4629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion interactive_engine/compiler/src/main/java/com/alibaba/graphscope/common/result/Utils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,10 @@ public static RelDataType getEdgeType(RelDataType graphPathType) {
return graphPathType;
}

public static String parseLabelValue(Common.Value value, GraphLabelType type) {
public static Object parseLabelValue(Common.Value value, GraphLabelType type) {
switch (value.getItemCase()) {
case NONE:
return null;
case STR:
return value.getStr();
case I32:
Expand Down
9 changes: 8 additions & 1 deletion ...ngine/compiler/src/main/java/com/alibaba/graphscope/cypher/result/CypherRecordParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,14 @@ protected AnyValue parseGraphPath(IrResult.GraphPath path, @Nullable RelDataType

protected AnyValue parseValue(Common.Value value, @Nullable RelDataType dataType) {
if (dataType instanceof GraphLabelType) {
return Values.stringValue(Utils.parseLabelValue(value, (GraphLabelType) dataType));
Object labelValue = Utils.parseLabelValue(value, (GraphLabelType) dataType);
if (labelValue == null) {
return Values.NO_VALUE;
} else if (labelValue instanceof String) {
return Values.stringValue((String) labelValue);
} else {
return Values.stringValue(labelValue.toString());
}
}
switch (value.getItemCase()) {
case BOOLEAN:
Expand Down
Loading