Skip to content

chore(execd): complete the work for #332, and fix the linter errors.#385

Merged
hittyt merged 5 commits intoalibaba:mainfrom
Pangjiping:feat/execd/uidgid
Mar 15, 2026
Merged

chore(execd): complete the work for #332, and fix the linter errors.#385
hittyt merged 5 commits intoalibaba:mainfrom
Pangjiping:feat/execd/uidgid

Conversation

@Pangjiping
Copy link
Collaborator

@Pangjiping Pangjiping commented Mar 8, 2026

Summary

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@jwx0925
Copy link
Collaborator

jwx0925 commented Mar 9, 2026

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b424f6ff8a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pangjiping Pangjiping added bug Something isn't working feature New feature or request labels Mar 12, 2026
Copy link
Collaborator

@hittyt hittyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hittyt hittyt merged commit 5fdf970 into alibaba:main Mar 15, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working component/execd feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a fallback to use sh instead of hardcoded bash

4 participants