Merged
Conversation
c129e76 to
5d3d55e
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d3d55e737
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
5d3d55e to
33427ed
Compare
33427ed to
6030927
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X-Request-IDsupport in SDK error surfaces so users can correlate client exceptions with server-side logs/traces.SandboxApiException(and base exception where applicable) across Kotlin / Python / JavaScript / C# SDKs.Scope
requestIdin API exceptions from adapters.extract_request_id(...)helper and wire into API/streaming/error-conversion paths.request_id.opensandbox>=0.1.5.requestIdto baseSandboxExceptionand keep passthrough viaSandboxApiExceptionoptions.RequestIdto baseSandboxExceptionand keep derived-property compatibility onSandboxApiException.Testing
Breaking Changes
Checklist
Linked Issue
X-Request-ID#267Follow-up
execdside still needsX-Request-IDsupport to complete end-to-end propagation consistency across all layers.Reference