Merged
Conversation
ninan-nn
requested review from
Generalwin,
Pangjiping,
hittyt and
jwx0925
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 737894909f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ninan-nn
force-pushed
the
feature/fix_server_pgk
branch
2 times, most recently
from
b3cd2a4 to
5c2bc8c
Compare
ninan-nn
force-pushed
the
feature/fix_server_pgk
branch
from
5c2bc8c to
510aea1
Compare
ninan-nn
force-pushed
the
feature/fix_server_pgk
branch
from
510aea1 to
876c1b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opensandbox_serveras the only published Python package.opensandbox_server/examplesand load them viaimportlib.resources.src/package layout and update server docs, Docker build paths, and tests to the new package path.Testing
Validation run locally:
./.venv/bin/python -m pytest -q671 passeduv build --wheelopensandbox_server/examples/example.config.tomlopensandbox_server/examples/example.config.zh.tomlopensandbox_server/examples/example.config.k8s.tomlopensandbox_server/examples/example.config.k8s.zh.tomlopensandbox_server/examples/example.batchsandbox-template.yamlBreaking Changes
Impact:
srcPython package path is removed.from src...and commands such aspython -m src.mainno longer work.Migration path:
opensandbox_serverfor all Python imports.python -m opensandbox_server.mainfor local module entry.opensandbox-serverfor the installed CLI.opensandbox-server init-config ...to generate example configs.Checklist