fix(server): normalize BatchSandbox create status#642
Open
Gujiassh wants to merge 1 commit intoalibaba:mainfrom
Open
fix(server): normalize BatchSandbox create status#642Gujiassh wants to merge 1 commit intoalibaba:mainfrom
Gujiassh wants to merge 1 commit intoalibaba:mainfrom
Conversation
Stop leaking the internal Allocated state once create_sandbox has already passed its usability gate, and cover the create-path contract with a focused regression test. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Gujiassh
requested review from
Generalwin,
Pangjiping,
hittyt,
jwx0925 and
ninan-nn
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_sandboxresponses to returnRunningonce the create wait gate has already accepted a BatchSandbox workload as usableAllocatedstate from the public create responseAllocatedtoRunningnormalization pathTesting
cd server && uv run pytest tests/k8s/test_kubernetes_service.py -k \"create_sandbox_with_valid_request_succeeds or create_sandbox_normalizes_allocated_status_to_running or wait_for_allocated_pod_returns_immediately\"cd server && uv run ruff check opensandbox_server/services/k8s/kubernetes_service.py tests/k8s/test_kubernetes_service.py