new CI workflow for linux.x86 #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge to 0.7, but master instead? |
beef9999
reviewed
Jun 3, 2024
| @@ -37,12 +37,12 @@ jobs: | |||
| source /opt/rh/gcc-toolset-9/enable | |||
| cmake -B build -D CMAKE_BUILD_TYPE=MinSizeRel -D PHOTON_BUILD_TESTING=ON \ | |||
| -D PHOTON_ENABLE_SASL=ON -D PHOTON_ENABLE_FUSE=ON -D PHOTON_ENABLE_EXTFS=ON | |||
| cmake --build build -j -- VERBOSE=1 | |||
| cmake --build build -j $(nproc) -- VERBOSE=1 | |||
There was a problem hiding this comment.
What's the default value of nproc? Didn't see the definition.
There was a problem hiding this comment.
it's the number of processors in current system.
beef9999
reviewed
Jun 3, 2024
CMake/build-from-src.cmake
Outdated
| BUILD_COMMAND sh -c "V=1 CFLAGS=\"-fPIC -g -O3 -Wall -Wextra -fno-stack-protector\" $(MAKE) -C src" | ||
| INSTALL_COMMAND $(MAKE) install | ||
| BUILD_COMMAND sh -c "V=1 CFLAGS=\"-fPIC -O3 -Wall -Wextra -fno-stack-protector\" $(MAKE) -C src" | ||
| # INSTALL_COMMAND $(MAKE) install |
beef9999
reviewed
Jun 3, 2024
examples/CMakeLists.txt
Outdated
| @@ -1,21 +1,21 @@ | |||
| add_definitions(-w) | |||
|
|
|||
| add_executable(simple-example simple/simple.cpp) | |||
| target_link_libraries(simple-example PRIVATE photon_static) | |||
| target_link_libraries(simple-example PRIVATE photon_shared) | |||
|
|
|||
There was a problem hiding this comment.
We'd better not change static libs to shared libs, because we usually need to copy example programs to other machines to run. An independent binary is convenient .
lihuiba
added a commit
to lihuiba/PhotonLibOS
that referenced
this pull request
Jun 3, 2024
new CI workflow for linux.x86
lihuiba
added a commit
to lihuiba/PhotonLibOS
that referenced
this pull request
Jun 3, 2024
lihuiba
added a commit
to lihuiba/PhotonLibOS
that referenced
this pull request
Jun 4, 2024
lihuiba
added a commit
to lihuiba/PhotonLibOS
that referenced
this pull request
Jun 4, 2024
Coldwings
pushed a commit
that referenced
this pull request
Jun 4, 2024
* new CI workflow for linux.x86 (#494)
lihuiba
added a commit
that referenced
this pull request
Jun 15, 2024
* new CI workflow for linux.x86 (#494) new CI workflow for linux.x86 * CI use images that pre-installed all deps (#505) * Manual pr 0.6 0.7 (#509) * FIX: lockfree MPMC queue should not fail to pop/push when queue is not empty/full (#504) * FIX: lockfree MPMC queue should not fail to pop/push when queue is not empty/full Signed-off-by: Coldwings <[email protected]> * Old CI image not able to access repo, change to preset image Signed-off-by: Coldwings <[email protected]> --------- Signed-off-by: Coldwings <[email protected]> Co-authored-by: Coldwings <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-threadinto 2 separate test suites, for ease of handling event engine overriding (see below)and it outputs: