fix dead lock in ExportPerformer #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihuiba
reviewed
Jun 8, 2024
| @@ -104,6 +108,8 @@ int callbackvoid(void*, AsyncResult<void>* ret) { | |||
| } | |||
|
|
|||
| TEST(ExportFS, basic) { | |||
| photon_init(); | |||
There was a problem hiding this comment.
why not doing init in main()?
There was a problem hiding this comment.
Other tests like ExportFS.no_xattr_sync run in pthread rather than photon thread.
fs/async_filesystem.cpp
Outdated
| std::condition_variable _cond; | ||
| bool _got_it = false; | ||
| typename AsyncResult<R>::result_type ret; | ||
| int err = 0; | ||
|
|
||
| AsyncWaiter() : _lock(_mtx) { } | ||
| AsyncWaiter() { } |
There was a problem hiding this comment.
no need for a ctor anymore
|
How about PR to 0.7 as well? |
will do it after this PR is approved. |
lihuiba
approved these changes
Jun 11, 2024
lihuiba
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an exported fs，ExportPerformer put called function to a SPSCRingQueue and wait to be waked when finished. Related code is below:
In situations where
_if->*funcis unimplemented, the function_if->*funcwill callw.done()directly, which cause a dead lock beacuse it try to lock a locked mutex.This pr do the following things:
ExportFS.no_xattr_syncto verify this dead lock behavior.fallocatefuction of ExportAsAsyncFile because this method is widely used in fuse.Besides, I marked the unittest ExportFS.xattr_sync as DISABLED for now. Because this test failed on MacOS only when compiled as release. Hope someone can fix it.