Fix sockpool wait_for_fd for old releases #554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coldwings
force-pushed
the
fix/sockpool_waitforfd_old_releases
branch
3 times, most recently
from
d7894fc
to
856056d
Compare
Coldwings
force-pushed
the
fix/sockpool_waitforfd_old_releases
branch
from
856056d
to
f30b83c
Compare
Coldwings
force-pushed
the
fix/sockpool_waitforfd_old_releases
branch
from
b1734db
to
596440a
Compare
lihuiba
reviewed
Sep 13, 2024
io/epoll.cpp
Outdated
| } | ||
| rm_interest({fd, interests, 0}); // no ONE_SHOT, to reconfig epoll |
There was a problem hiding this comment.
it's might be safer to rm_interest(event) as before.
io/kqueue.cpp
Outdated
| if (ret < 0) return errno == ETIMEDOUT ? 0 : -1; | ||
| if (count > LEN(_events)) | ||
| count = LEN(_events); | ||
| static const struct timespec _tm = {0, 0}; |
There was a problem hiding this comment.
Why static here, while not in enqueue()?
There was a problem hiding this comment.
Use on-stack temporary timespec is fine. Changed in latest commit.
|
Discussed that old version may not need such fix. This fix will be dropped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #553 but for dev/0.6