case-insensitive map_string_key #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihuiba
force-pushed
the
map_string_key_ignore_case
branch
from
035b530
to
2d36130
Compare
Coldwings
reviewed
Sep 26, 2024
| assert(sv.size() <= BUF_CAP); | ||
| for (size_t j = 0; j < sv.size(); ++j) | ||
| buf[j] = (char)tolower(sv[j]); | ||
| return std::hash<std::string_view>()({buf, n}); |
There was a problem hiding this comment.
Might be better if using template parameter to set hasher (and even combine hasher) for parts instead of std::hash<std::string_view>.
hasher for unordered_map_string_key can be set by template parameter, so unordered_map_string_key_case_insensitive would be better able to set hasher.
lihuiba
force-pushed
the
map_string_key_ignore_case
branch
from
2d36130
to
ab96c76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.