retval refinement #582
Merged
retval refinement #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lihuiba
commented
Oct 1, 2024
| @@ -26,7 +26,9 @@ GTEST_API_ int main(int argc, char **argv) { | |||
| #endif | |||
|
|
|||
| // Initialize state-threads, create idle coroutine. | |||
| assert(st_init() == 0); | |||
There was a problem hiding this comment.
assert() can be removed if NDEBUG is defined, and st_init() is missed.
lihuiba
force-pushed
the
retval_refinement
branch
11 times, most recently
from
153747e
to
37d55db
Compare
lihuiba
force-pushed
the
retval_refinement
branch
from
37d55db
to
064acbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.