add set body buffer for http client #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihuiba
reviewed
Dec 17, 2024
liulanzheng
force-pushed
the
release/0.8
branch
4 times, most recently
from
5b111a8 to
0a86f84
Compare
lihuiba
reviewed
Dec 18, 2024
| @@ -106,6 +122,8 @@ class Client : public Object { | |||
| explicit Operation(uint16_t buf_size) : req(_buf, buf_size), _client(nullptr) {} | |||
| Operation() = delete; | |||
| ~Operation() = default; | |||
|
|
|||
| friend class ClientImpl; | |||
There was a problem hiding this comment.
ClientImpl is a sub-class of Client. There's no need be friend?
There was a problem hiding this comment.
could not compile
Signed-off-by: liulanzheng <[email protected]>
liulanzheng
force-pushed
the
release/0.8
branch
from
0a86f84 to
8e342a7
Compare
lihuiba
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.